Conversation
Closed
1 task
gnksbm
approved these changes
Mar 24, 2025
| return serverKey | ||
| } | ||
|
|
||
| static var alarmServerURL: Self { |
Contributor
There was a problem hiding this comment.
Core 모듈에서 모든 String extension을 관리하는 형태가 조금 걸리긴하네요.
해당 변수는 Data 모듈에서만 사용되어야 할 것 같은데 다른 모듈들이 접근 가능한 점이 조금 신경쓰였어요!
추후 리팩토링이 진행된다면 분리하면 좋을 것 같습니다!
Contributor
Author
There was a problem hiding this comment.
사실 core - extension/string+에 끼워넣으면서도 그 고민을 했었는데, 도메인 변경이 급한 부분이라 우선 이대로 적용하고 추후 변경하는 방향으로 하면 좋을 것 같습니다!
MUKER-WON
reviewed
Mar 24, 2025
Plugins/EnvironmentPlugin/ProjectDescriptionHelpers/InfoPlist.swift
Outdated
Show resolved
Hide resolved
MUKER-WON
approved these changes
Mar 24, 2025
Contributor
MUKER-WON
left a comment
MUKER-WON
left a comment
There was a problem hiding this comment.
잊고 있었는데 서버 만료 대응해주셔서 감사합니다
수고하셨어요!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업내용
서버 및 도메인 만료로 인한 변경사항 적용
리뷰요청
관련 이슈
close #322